[Bug 166183] Review Request: perl-Class-Accessor-Chained

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Class-Accessor-Chained


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166183





------- Additional Comments From chris at chrisgrau.com  2005-08-20 02:08 EST -------
Good:

- rpmlint clean
- package name okay
- spec file name okay
- license okay (GPL or Artistic)
- license matches upstream
- spec file is am. english (and legible)
- source matches upstream (md5: 9825a1f30a70e55e61bb5660b2bd7365)
- package builds on FC-4/i386
- package builds in mock (FC-3/i386)
- no locales
- no shared libs
- not relocatable
- owns all directories it creates
  (/usr/lib/.../Class owned by perl-Class-Accessor, a prereq)
- file permissions okay
- %clean okay
- consistent use of macros
- code, not content
- no -docs package
- %doc does not affect runtime
- no -devel package

Needswork:

> BuildRequires: perl >= 1:5.6.1

I'm on the fence over whether BR: perl should be included for perl modules. 
It's currently on the ForbiddenItems page, so I'm going to go with not, until
such time as it's removed or an exception is made for perl modules.

- README not in %doc

The README is in POD format.  Maybe pass it through pod2text in %prep?

- no license text in %doc

I let the last few slide without this because I was under the (obviously false)
impression that Perl modules, not being shipped with a license themselves, could
ignore this.  As mentioned in bug 166251, adding

  perldoc -t perlartistic > Artistic
  perldoc -t perlgpl > COPYING

in %prep and then adding them to %doc will do the job without the need to change
anything more than the spec file.

> $ grep -r 'use base' *
> lib/Class/Accessor/Chained/Fast.pm:use base 'Class::Accessor::Fast';
> lib/Class/Accessor/Chained.pm:use base 'Class::Accessor';
[irrelevant results snipped]

=> explicit requires needed for perl(Class::Accessor) and
perl(Class::Accessor::Fast)

Nitpicks:

- make called without %{_smp_mflags}

- %description is just %{summary}

I haven't mentioned it before, but I usually use the first paragraph or two from
the DESCRIPTION section of the main module's POD.  It's usually fitting.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.