[Bug 165485] Review Request: This is a port of WMApm 1.1 with ACPI support

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: This is a port of WMApm 1.1 with ACPI support


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165485


jamatos at fc.up.pt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From jamatos at fc.up.pt  2005-08-20 06:39 EST -------
+ Builds inside mock on x86_64 
+ rpmlint output: 
W: wmacpi no-version-in-last-changelog 
 
  I guess that is due to the version being in the next line. Easy to fix. 
 
+ package name follows rules 
+ the spec file is named correctly, it is written in English and it is legible 
+ the license is correct (GPL), the same as upstream and it is included in 
%doc 
+ The source file matches upstream. (sha1sum) 
+ BR are correct 
+ there are no locales, %post*, devel or doc subpackages to worry about 
+ the package is not relocatable 
+ there is no directory to be owned, and file permissions are correct 
 
I still do not like the description, I would expect something like (I took 
this from the web page with some small changes): 
 
This is a typical laptop ACPI dockapp. One interesting feature is the "timer" 
mode, where you can keep track of how long the laptop has been "on battery". 
This is opposite of the information usually provided by the BIOS, which is 
"time remaining", and in many cases wrong. This option can be toggled at 
run-time. System messages scroll on the bottom of the window, AC plug flashes 
when battery is charging, and green LED inside the big button flashes red if 
battery level is critical low. 
 
I think that the word laptop is also missing in the the Summary field, I think 
that you agree that this is only usefull for laptops. I am not aware of any 
desktop with an included battery. ;-) UPS does not count as such, at least for 
this program scope :-). 
 
I noticed that this program does not give any reliable information if you have 
two battery plugs and only the second one is present. But this is an upstream 
issue. 
 
The package is APPROVED. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.