[Bug 166184] Review Request: perl-Class-DBI : Simple Database Abstraction

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Class-DBI : Simple Database Abstraction


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166184


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
  BugsThisDependsOn|                            |166197, 166198, 166201,
                   |                            |166567
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-08-24 08:27 EST -------
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec
- spec file legible and written in English
- sources match upstream
- builds OK in mock on FC-4 (i386)
- BR's mostly OK
- no locales, subpackages, libraries, pkgconfigs etc. to worry about
- not relocatable
- directory ownership OK
- no duplicate files or permission issues
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets

Needswork:

- redundant BR: perl
- license text not included in package; suggest adding to %prep:
  perldoc -t perlgpl > COPYING
  perldoc -t perlartistic > Artistic
  and to %files:
  %doc COPYING Artistic

Nitpick:

- include BR: perl(Date::Simple) for more test coverage

Note:

- Including a BR: perl(Time::Piece::MySQL) would also improve coverage but this
  is not yet available in Extras or submitted for review, but it's worth adding
  at some point if someone submits that package



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.