[Bug 166698] Review Request: perl-Time-Piece - Time objects from localtime and gmtime

bugzilla at redhat.com bugzilla at redhat.com
Wed Aug 24 20:58:47 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Time-Piece - Time objects from localtime and gmtime


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166698





------- Additional Comments From chris at chrisgrau.com  2005-08-24 16:58 EST -------
(In reply to comment #1)
> - I believe the CFLAGS setting in:
>   CFLAGS="$RPM_OPT_FLAGS" %{__perl} Makefile.PL INSTALLDIRS=vendor
> OPTIMIZE="$RPM_OPT_FLAGS"
>   is redundant and you could use:
>   %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
>   instead.

Now that I take a closer look, that does seem awfully redundant.  Maybe the
spectemplate-perl.spec should be updated.  I had just copied that and moved the
OPTIMIZE argument based on the ExtUtils::MakeMaker documentation.

Nitpicks applied:
http://www.chrisgrau.com/packages/perl/perl-Time-Piece.spec
http://www.chrisgrau.com/packages/perl/perl-Time-Piece-1.08-2.src.rpm

I didn't use your patch, Paul (made the updates before I noticed it), but I
appreciate the effort.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list