[Bug 166199] Review Request: perl-Data-Page : Help when paging through sets of results

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Data-Page : Help when paging through sets of results


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166199


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
  BugsThisDependsOn|                            |166183
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-08-25 07:00 EST -------
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, spec matches
- spec written in English and is legible
- sources match upstream
- package builds OK in mock for FC4 (i386)
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership or permissions errors
- %clean section present and correct
- macro usage consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets

Needswork:

- explicit Requires: perl(Class::Accessor::Chained::Fast) needed, not picked up
automatically

Nitpick:

- redundant BR: perl
- license text not included; suggest the usual fix
- suggest including CHANGES as %doc
- make called without %{?_smp_mflags}
- BR: perl(Class::Accessor::Chained) should really be
perl(Class::Accessor::Chained::Fast), though the same package provides both
- add BR: perl(Test::Pod) & perl(Test::Pod::Coverage) for improved test cover


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.