[Bug 166515] Review Request: pbzip2 : parallel version of bzip2

bugzilla at redhat.com bugzilla at redhat.com
Thu Aug 25 15:16:51 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pbzip2 : parallel version of bzip2


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166515


oliver at linux-kernel.at changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gdk at redhat.com              |oliver at linux-kernel.at




------- Additional Comments From oliver at linux-kernel.at  2005-08-25 11:16 EST -------
First climpse i took:
Good:
  * Group Applications/File is the same as bzip2 and therefor a good choice
  * License BSD, is OK. The README says the same
  * tmppath OK
  * Consitant use of tags
  * changelog ok

Bad:
 * Remove Vendor/Packager Tags
 * Use rm -rf %{buildroot}, and forget the [ ... ] check
 * Remove the cleanup of the buildroot in the %prep-section
 * Run rpmlint:
   - W: pbzip2 strange-permission pbzip2.spec 0600
 * Builds find
 * Installs/Uninstalls fine
 * Owns all files it installs.
 * Works. :-)

Notes:
 * You can drop bzip2-libs from requires, as RPM will detect libbz2.so.1 as
requirement.


If you fix the above stuff, I'll review again. If it's OK, I'll approve it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list