[Bug 166713] Review Request: perl-GnuPG-Interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-GnuPG-Interface


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166713


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-08-25 13:30 EST -------
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec
- spec written in English and is legible
- sources match upstream
- builds OK on FC4 and in mock for rawhide (i386)
- buildreqs OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets

Nitpick:

- %check output can be cleaned somewhat by adding "chmod 700 test" before "make
test"
- any idea what's happening here?

+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/clearsign................ok
t/decrypt..................ok
t/detach_sign..............ok
t/encrypt..................ok 1/3unknown record type tru at
blib/lib/GnuPG/Interface.pm (autosplit into
blib/lib/auto/GnuPG/Interface/get_keys.al) line 548, <GEN27> line 1.
t/encrypt..................ok
t/encrypt_symmetrically....ok
t/export_keys..............ok
t/Fingerprint..............ok
t/get_public_keys..........unknown record type tru at
blib/lib/GnuPG/Interface.pm (autosplit into
blib/lib/auto/GnuPG/Interface/get_keys.al) line 548, <GEN14> line 1.
t/get_public_keys..........ok
t/get_secret_keys..........ok
t/import_keys..............ok
t/Interface................ok
t/list_public_keys.........ok
t/list_secret_keys.........ok
t/list_sigs................ok
t/passphrase_handling......ok
t/sign.....................ok
t/sign_and_encrypt.........ok
t/UserId...................ok
t/verify...................ok
t/wrap_call................ok

- for an FC3 build you don't need the patch, so you could maintain a different
  spec in the FC3 branch, or conditionally apply the patch:

%if 0%{?fedora} > 3
%patch0 -p1
%endif

- license text not included in package; suggest adding to %setup:
perldoc perlgpl > GPL
perldoc perlartistic > Artistic
  and to %files:
%doc GPL Artistic

- although "BuildReq: gpg" works, might "gnupg" be better?



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.