[Bug 166626] Review Request: xscorch - A Scorched Earth clone

bugzilla at redhat.com bugzilla at redhat.com
Thu Aug 25 21:43:44 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xscorch - A Scorched Earth clone


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166626





------- Additional Comments From bugs.michael at gmx.net  2005-08-25 17:43 EST -------
Well, to be precise, it's strcopyb as strcopyn would need a buffer
of size n+1.

And strlenn is a preprocessor macro, STRLENN, which is just strlen().

But indeed, the STRNCPY macro inserts a null at pos n-1.

You won't convince me to like such "C string" hacks, when a few lines
below in saddconf.c you do manual size+1 calculations for malloc and
strcopyn nevertheless.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list