[Bug 166492] Review request: perl-Cache-Simple-TimedExpiry - Cache::Simple::TimedExpiry Perl module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review request: perl-Cache-Simple-TimedExpiry - Cache::Simple::TimedExpiry Perl module


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166492


jpo at di.uminho.pt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gdk at redhat.com              |jpo at di.uminho.pt
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From jpo at di.uminho.pt  2005-08-26 07:42 EST -------
MD5SUMS:
7dbe43ec53dcdb4496fcd5cf17e975ed  perl-Cache-Simple-TimedExpiry-0.23-1.src.rpm

35cb46fc96272591db75491c9250a48d  Cache-Simple-TimedExpiry-0.23.tar.gz
048f45dfcbb83a542cafec61efc289a9  perl-Cache-Simple-TimedExpiry.spec

Sources:
* Cache-Simple-TimedExpiry-0.23.tar.gz: MD5 digest verified against CPAN tarball

Good:
* Package name follows standard
* URL is valid
* License verified (Makefile.PL and main URL)
* perl(:MODULE_COMPAT_xxx) present
* perl vendor libs present
* File permissions OK
* Builds without problems in FC-3 and FC-4
* No entries in
  http://rt.cpan.org/NoAuth/Bugs.html?Dist=Cache-Simple-TimedExpiry

NeedsWork:
* Source0 should be an URL
  Examples:
  http://www.cpan.org/authors/id/J/JE/JESSE/Cache-Simple-TimedExpiry-0.23.tar.gz
 
http://www.cpan.org/authors/id/J/JE/JESSE/Cache-Simple-TimedExpiry-%{version}.tar.gz

Other notes and nitpicks:
* change the summary to
  "A lightweight cache with timed expiration"
  Source: YAML file
* add the Changes file to %doc list
* insert a blank line before the %changelog section
* remove duplicate entry in changelog
  "* Tue Mar 22 2005 Ralf Corsepius <ralf at links2linux.de> - 0.23-0.pm.2"

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.