[Bug 165955] Review Request: grads Grid Analysis and Display System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: grads Grid Analysis and Display System


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165955





------- Additional Comments From ed at eh3.com  2005-08-28 20:50 EST -------
Hi Patrice, heres an incomplete review.  Please post an SRPM that builds
and I'll re-review (and probably approve since the fixes are minor).

needswork:
 - build fails with:
     Error: File not found:
       /var/tmp/grads-1.9b4-2-root-edhill/usr/bin/gradsdods
   which can be fixed by removing:
     %{_bindir}/gradsdods
 - lots of warnings about ignored return values from or implicit 
   re-definitions of fread, fwrite, sscanf, strncpy, etc. which 
   can perhaps be ignored but are worrisome
 - after removing "%{_bindir}/gradsdods", the package builds and 
   rpmlint reports:
      W: grads wrong-file-end-of-line-encoding 
         /usr/share/doc/grads-1.9b4/html/reference_card.pdf
      W: grads wrong-file-end-of-line-encoding 
         /usr/share/doc/grads-1.9b4/html/GrADS.css
      W: grads wrong-file-end-of-line-encoding 
         /usr/share/doc/grads-1.9b4/html/reference_card_scl.pdf
   which can probably be ignored

good:
 - source matches upstream
 - dir ownership and permissions look good
 - names and specfile look OK
 - license is included and looks OK
 - code not content
 - docs look OK
 - no need of -devel package

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.