[Bug 165878] Review Request: kadu

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kadu


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165878





------- Additional Comments From gajownik at gmail.com  2005-08-30 06:55 EST -------
Sorry that it took me so long but I was a bit busy recently :/
(In reply to comment #1)

> Maybe "aRts module for Kadu" would be better?

This also applies to the "Summary" fields ;-)

(In reply to comment #2)

> I can't avoid underscore in package name becouse it is module name.

OK.

> Files are used by Kadu in About window so they must be in that path.

Oh, I didn't know about it.

I missed few things:
- remove hardcoded path from the kadu.desktop path:

Exec=kadu -caption "%c" %i %m

should be sufficient.
- in Categories field you can add "Qt" and maybe "KDE":
http://standards.freedesktop.org/menu-spec/latest/apa.html
This site does not mention "X-KDE-Base" so I'm not shure whether it's valid
entry :/ (help)
- drop these lines:

Requires:       qt >= 3.2
Requires:       libsndfile >= 1.0.11

RPM automatically detects proper requirements. What is more, Fedora Core and
Extras (FC3+) provide appopriate versions of these libraries.
- don't include /usr/lib/debug in the devel package
- architecture dependent files (modules) are in /usr/share directory - that's
against FHS 2.3 standard
http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREARCHITECTUREINDEPENDENTDATA
I would suggest contacting with upstream and urge them to move these files to 
/usr/lib/kadu
http://www.pathname.com/fhs/pub/fhs-2.3.html#USRLIBLIBRARIESFORPROGRAMMINGANDPA
- modules are not stripped

And one more thing which looks weird to me - rpmlint warns about too long line
in description. Maybe it counts non-US-ASCII characters as two characters?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.