[Bug 166194] Review Request: perl-Class-DBI-Plugin-Type : Determine type information for columns

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Class-DBI-Plugin-Type : Determine type information for columns


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166194


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-08-31 06:46 EST -------
Review:

- rpmlint clean
- package and spec file naming OK
- package meets guidelines
- license is same as perl, matches spec
- spec written in English and legible
- source matches upstream
- builds OK in mock for FC4 (i386)
- BR's mostly OK
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets

Needswork:

- redundant BR: perl
- BR: perl(DBD::SQLite) needed for %check
- license text not included

Nitpick:

- suggest using %{?_smp_mflags} with make in %%build


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.