[Bug 173671] Review Request: xfce4-weather-plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-weather-plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173671





------- Additional Comments From fedora.wickert at arcor.de  2005-11-30 20:54 EST -------
(In reply to comment #1)
> Hi, 
> 
> Using yum-builddep, I noticed there are missed packages for BuildRequires:
> - libxfce4gui-devel

Added

> - libxfce4util-devel

false positive, pulled automatically by xfcegui-devel.

> - libxfce4mcs-devel

I can't see where this depends on libxfce4mcs-devel:
checking XFCE4_PANEL_CFLAGS... -DXTHREADS -D_REENTRANT -DXUSE_MTSAFE_API
-I/usr/include/xfce4 -I/usr/X11R6/include -I/usr/include/libxml2
-I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/pango-1.0
-I/usr/include/freetype2 -I/usr/include/freetype2/config -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/atk-1.0
checking XFCE4_PANEL_LIBS... -L/usr/X11R6/lib -lxfcegui4 -lxml2 -lpthread -lz
-lgtk-x11-2.0 -lxfce4util -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lm
-lpangoxft-1.0 -lpangox-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0

> 
> Also check out if there is a Requires for that plugin.

Nope, AFAIK not. 

> 
> When it comes to BSD, could specify it is the original or the modified license.
> I think other developers five a very good explaination to avoid confusion.

This is the "New BSD License" from 
http://www.opensource.org/licenses/bsd-license.php

New SRPM
http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-weather-plugin-0.4.9-4.fc4.src.rpm
Updated SPEC
http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/xfce4-weather-plugin.spec


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.