[Bug 168310] Review Request: swish-e <bkyoung>

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: swish-e <bkyoung>


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168310





------- Additional Comments From bkyoung at users.sourceforge.net  2005-12-05 22:16 EST -------
#60 was more complicated. After the changes, the paths had to be adjusted, yes,
but PERL5LIB and LD_LIBRARY_PATH had to be re-added. This does not affect
runtime. The 20.fc5 package fails check-rpaths if the spec sed LD_RUN_PATH line
is commented out with/without Swish-e installed.

Added a swish-e-default sub-package, which helps for testing purposes (needed!).
Perhaps a bit much for Extras?

Thanks to the fedora-devtool guys for tools to catch these problems.

Because of all these minute changes, I've verified the package yet once again:

PackagingGuidelines
* Normal package naming ok.
*   Upstream name contains dash '-', but ok.
*   Addon Perl sub-packages match CPAN, but some use all capitols.
*   Doc subpackage -doc ok.
*   spec file name ok.
*   Version matches upstream.
*   %{?dist} used correctly in Release.
* Legal: Includes OSI/GPL.
* No Packager, Vendor, or Copyright tags.
* Good buildroot tag.
* Requires look good. Patch requires specific libxml2. 
* BuildRequires looks good.
* Summaries/Descriptions ok. American English and Spelling.
* Spec file  ASCII.
* -doc sub-package. Group: Documentation.
* Includes libraries.
*   No .la or static libs.
*   Devel subpackage used.
* %config(noreplace) used.
* Macros use ok.
* RPM_BUILD_ROOT/RPM_OPT_FLAGS variable style.
* Uses %{__make} %{?_smp_mflags} instead of make %{?_smp_mflags}
* Conditional dependencies not required.
* Not relocatable.
* Content ok (documentation).

ReviewGuidelines
* MUST Items
*   Rpmlint ok.
*   Name ok.
*   Spec ok.
*   Packageguidelines ok.
*   License OSI/GPL.
*   License in doc of primary package.
*   License field matches included license.
*   Spec file in American English.
*   Spec file not a Obfuscated  Code Contest candidate.
*   UNABLE TO VERIFY MD5SUM UPSTREAM.
*   Build on FC4/FC5-test1 i386
*   No dups.
*   Good perms.
*   %clean ok.
*   Macros ok.
*   Content ok and code ok.
*   Large doc => -doc package.
*   No runtime files in -doc.
*   Headers in -devel subpackage.
*   No pkgconfig used.
*   Devel contains .so.
*   All subpackages require versioned base as dependency.
*   No .la or static libs.
*   No gui apps.
* SHOULD Items.
*   Package tests properly on i386.

OTHER
* Proper use of ldconfig
* Package owns all files/directories it should
* Owns all directories it uses
* Builds with package already installed.
* Build test ok with package already installed.
* Builds without package installed.
* Build test okay without package installed.

Definition of testing the package:
After build, then package install:
cd BUILD/swish-e-2.4.2/perl
perl t/test.t
echo $? == 0

Configuring swish-e-default according to README.default
lynx url/cgi-bin/swish.cgi
runs and entering a search term "swish" returns a results list.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.