[Bug 174275] Review Request: nautilus-actions - Nautilus extension for customizing the context menu

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nautilus-actions - Nautilus extension for customizing the context menu


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174275





------- Additional Comments From bdpepple at ameritech.net  2005-12-07 15:32 EST -------
NEEDSWORK

MD5Sums:
682d452e4b05c77b5a258c7ec49634bc  nautilus-actions-0.99.tar.gz

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* Desktop entry is fine
* All directories are owned by this or other packages
* No deprecated fields used
* All necessary BuildRequires listed.
* All desired features are enabled
* Package rebuilds as non-root user
* Make succeeds even when %{_smp_mflags} is defined
* Files have appropriate permissions and owners

Needswork:
* In the %pre section, you scriptlet needs to be changed, the [NAME] should be
changed to config_newaction.

* Rpmlint errors:
E: nautilus-actions description-line-too-long
W: nautilus-actions conffile-without-noreplace-flag
/etc/gconf/schemas/config_newaction.schemas
W: nautilus-actions devel-file-in-non-devel-package /usr/bin/nautilus-actions-config
W: nautilus-actions devel-file-in-non-devel-package
/usr/bin/nautilus-actions-new-config

* The line where you remove the fedora*.desktop file can be removed, since it
comes before where the desktop file is created & installed.  The
--delete-original switch handles the .desktop file that comes with the source.

* It seems redundant to include both the AUTHORS & MAINTAINERS files, since the
MAINTAINER file only contains their e-mail addresses, which is also included in
the AUTHORS file.  I would suggest not packing the MAINTAINERS file.


Notes:
I'm not running Rawhide, so I'm not able to verify that this runs correctly.  It
does build fine in Mock, though.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.