[Bug 174866] Review Request: polypaudio: Improved Linux sound server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: polypaudio: Improved Linux sound server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174866





------- Additional Comments From Christian.Iseli at licr.org  2005-12-08 17:45 EST -------
(In reply to comment #9)
> Note that packages that don't insist doing chown/chgrp but do chmod
> setuid/setgid are unaffected wrt. being buildable by unprivileged users, and the
> '-'s in eg. %defattr(-,root,root,-) will do the right thing regarding the files'
> ownership.

After building and installing the package, I get (on my FC4, x86_64 box):
root: ls -al /usr/bin/polypaudio
-rwsr-xr-x  1 root root 632416 Dec  8 23:35 /usr/bin/polypaudio

So, I stand by my (humble) opinion that the guidelines should mandate no
chown/chmod in %install, and use of %attr in %files.  This way, it is much
clearer which packages introduce suid binaries.

> rpmbuild not stripping setuid/setgid binaries is a different,
> orthogonal issue.

Right.  And quite useful as a warning :-)

BTW, rpmlint on x86_64 is noisy about rpath:
E: polypaudio binary-or-shlib-defines-rpath /usr/bin/polypaudio ['/usr/lib64']
E: polypaudio binary-or-shlib-defines-rpath /usr/bin/paplay ['/usr/lib64']
E: polypaudio binary-or-shlib-defines-rpath /usr/bin/pacat ['/usr/lib64']
E: polypaudio binary-or-shlib-defines-rpath /usr/bin/pactl ['/usr/lib64']

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.