[Bug 175844] Review Request: wmx -- really simple and basic X window manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wmx -- really simple and basic X window manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175844





------- Additional Comments From lemenkov at newmail.ru  2005-12-15 16:50 EST -------
Needs some work:

> Source0: %{name}-%{version}.tar.gz

Use only internet-names, like:

 Source0: http://www.all-day-breakfast.com/wmx/wmx-6.tar.gz

I can't find where can I download examples.

> BuildRoot: %{_tmppath}/%{name}-root

Use the following string:

 BuildRoot: 	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

> make

It's always a good idea to use the following expression instead of plain "make":

 %{__make} %{?_smp_mflags}

> rm -rf %{buildroot}

Instead, use:

 %{__rm} -rf %{buildroot}

and so on...

You'd better to look at the spec-files which conforms the fedora-extras rules.
You may find 'em  at the:

http://cvs.fedora.redhat.com/viewcvs/devel/?root=extras

Anyway, it's a good idea to include a lightweight wm info FE. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.