[Bug 173028] Review Request: ser - SIP Express Router

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ser - SIP Express Router


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173028


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |jpmahowald at gmail.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2005-12-16 18:17 EST -------
RFC is actually 3261

Needs a bit of work: (courtesy of fedora-qa script)

* RPM name is OK
* Source ser-0.9.4_src.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock


Needs work:
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* Spec file: tag Vendor is forbidden
  (wiki: PackagingGuidelines#tags)
* The BuildRoot must be cleaned at the beginning of %install
* rpmlint of ser: init script can be without no replace, and should be
executable. But it should not be enabled by default.
* rpmlint of ser-mysql: Simply remove the . from the summary.
* rpmlint of ser-jabber: Another period to remove.
* rpmlint of ser-cpl-c: Yet another period.
* rpmlint of ser-pa: Remove .
* rpmlint of ser-postgres: Remove .
* File list of ser: Move the /usr/etc heirarchy to /etc.
* Missing dependancy on service for %preun (package initscripts)
* Missing dependancy on chkconfig for %post (package chkconfig)
* Missing dependancy on chkconfig for %preun (package chkconfig)
* Scriptlets: missing "service" in %postun (wiki: ScriptletSnippets) (in
subpackage ser)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.