[Bug 174181] Review Request: python-simpy Python simulation framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-simpy Python simulation framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174181





------- Additional Comments From sarantis at cnl.di.uoa.gr  2005-12-21 07:55 EST -------
(In reply to comment #1)
> SimGUI doesn't work, rpm isn't picking up that it needs Tkinter. Requires:
> tkinter needed.

done.

> The spec file doesn't seem to be encoded in ASCII or URF-8. Please save in one
> or the other. file says "python-simpy.spec: lex description text"

It is ASCII though. file -i says 
python-simpy.spec: text/x-java; charset=us-ascii
I think the first lines confuse the guessing done by file's logic.

> - rpmlint does not output anything
> 
> I would not call this python-simpy, simpy is sufficient, as it is not a python
> extension but a SIMulation in PYthon. Debian seems to call it python-simpy,
> however. Your choice.

It is not a standalone application, but a simulation framework.  One writes
simulations in python using this framework, so I think I'll keep the name.

> You removed the source documentation. Consider packaging it as a seperate docs
> subpackage.

done.

> The patch removes all shebangs. Why, is this to quiet rpmlint?

Yes.  I have no strong feelings on this, I can remove it.  The modules from
which the shebangs are removed are not supposed to be executed directly, and
some example scripts I wrote did not show any problems with this patch.
I'll take it upstream anyway to see what the authors think.

Thanks for the review.

New versions:
http://gallagher.di.uoa.gr/rpms/python-simpy/python-simpy.spec
http://gallagher.di.uoa.gr/rpms/python-simpy/python-simpy-1.6.1-2.src.rpm
http://gallagher.di.uoa.gr/rpms/python-simpy/python-simpy-1.6.1-2.noarch.rpm
http://gallagher.di.uoa.gr/rpms/python-simpy/python-simpy-doc-1.6.1-2.noarch.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.