[Bug 174240] Review Request: artwiz-aleczapka

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: artwiz-aleczapka


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174240


gajownik at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gdk at redhat.com              |gajownik at gmail.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From gajownik at gmail.com  2005-12-25 11:51 EST -------
(In reply to comment #4)
> Ping?

Uhm, sorry that it took me so long. I was ill a bit and after that I had a lot
of duties. Sleeping 4-6 hours per day I was trying to catch up on my work. I
thought that someone more knowledgeable could make a review in the meantime.

(In reply to comment #2)
> Hm, I think you we want the source files

It depends. Some *-fonts packages use pregenerated fonts. Of course, it's
nothing wrong in providing source files in src.rpm ;-]

> I don't know weather it should also be run from %{_datadir}/fonts to allow for
> integration...

Without it fonts won't be visible in the system. In your fluxbox package you
were adding these directories by modifying /etc/fonts/local.conf. Here you only
need to run fc-cache in that dir because %{_datadir}/fonts is already in
/etc/fonts/local.conf.

> and point out diffs between FC{3,4,5}?

In FC5 there is additional fonts.cache-2 file.

(In reply to comment #3)
> Ok here you go: added fc-cache to post and require it (so we don't need the if's
> like in dejavu)

That's wrong. Please take a look at these links:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165900#c1
http://www.redhat.com/archives/fedora-extras-list/2005-May/msg00887.html

Here's the rest of review:
- do not run fc-cache in %build section. It's a Bad Thing™ →
https://bugs.freedesktop.org/show_bug.cgi?id=5176#c1 (Mike A. Harris is a
maintainier of X.Org X11 in Fedora/RedHat)
- do not include source files (*.bdf) in the final package
- please preserve timestamps →
http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps (I changed "mv"
command to "install -p"

I prepared a small patch. I have cleaned up a bit %prep section and installed
fonts into %{_datadir}/fonts/artwiz-aleczapka directory (not
artwiz-aleczapka-fonts). I'm also not shure whether “%{version}” part is
necessary in %{buildroot}%{fontdir}/artwiz-aleczapka-{de,en,se}-%{version}. Oh,
I also did not have time to struggle with documentation files. It needs some
more work...

BTW Merry Christmas :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.