[Bug 176542] Review Request: gnome-yum - GNOME interface for YUM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-yum - GNOME interface for YUM


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176542


pmatilai at laiskiainen.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pmatilai at laiskiainen.org




------- Additional Comments From pmatilai at laiskiainen.org  2005-12-26 10:57 EST -------
This is not a full review but a couple of comments:
- The consolehelper symlinks don't belong to %post/%postun scriptlets, package
them along with other content in %install
- You should add dependency on usermode(-gtk) for the above
- GConf2, vte, gnome-vfs2 dependencies are probably automatically detected by
rpmbuild, if so they should be removed as redundant
- Requires: rpm is silly - you must have rpm installed to install an rpm anyway
- Adding 3rd party repositories containing known legally problematic packages is
not allowed, the fedora-repositories subpackage and any references to those
repositories needs to be removed.
- The for-loop for copying the docs is redundant, just use
  %doc ABOUT-NLS AUTHORS README... in %files section
- I'd suggest using %find_lang macro instead of the current
{_datadir}/locale/*/LC_MESSAGES/gnome-yum.mo in %files

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.