[Bug 176006] Review Request: Streamtuner - a stream directory browser.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Streamtuner - a stream directory browser.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176006


bugs.michael at gmx.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |bugs.michael at gmx.net
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From bugs.michael at gmx.net  2005-12-27 11:14 EST -------
After a first look...

streamtuner-devel package:

 * Missing "Requires: gtk2-devel" because else it would break the
   pkgconfig dependency chain.

 * The Cflags line in the pkgconfig file is bad. It ought not add
   -I/usr/include because that is a standard search path for header
   files already.

 * The included static libraries and libtool archives are _highly_
   questionable. Unless you can state a very good reason why static
   versions of the plugin (!) DSOs should be shipped, delete them after
   %install or %exclude them in the %files section.

streamtuner binary package:

 * Category X-Red-Hat-Base in .desktop file is wrong. Should be X-Fedora,
   because this is not Fedora Core.

Run-time observation:

 * Clicking "Browse" button or "Help > Homepage" menu gives fatal
   error dialog:

    Unable to browse
    Failed to execute child process
    "epiphany" (no such file or directory)

   Looks like either a missing customisation or a missing
   dependency.

 * "xmms" also seems to be another missing requirement, as an
   error dialog pops up upon trying to tune in to a station.

 * "Record" button fails with 
    
    xterm: Can't execvp streamripper: No such file or directory

   Looks like more missing dependencies: "xterm", and do we have
   "streamripper" anywhere yet?

spec file issues:

 * Licence GPL is wrong. The included file COPYING contains is "BSD"
   licence text. The C source files don't mention GPL either.

 * Requires: gtk2 >= 2.2.2, curl >= 7.10.8, taglib >= 1.3, libidn >= 0.5.6
   All of these must go. There are automatic RPM dependencies on the
   needed SONAMEs already. Check out "rpm -qR streamtuner". Package
   resolvers know which packages to install in order to get the required
   libraries.

 * Requires: pygtk2 >= 2.4.0
   At a first glance it doesn't become clear why this dependency was added.

 * Concerning all those versions in the [build] requirements, consider
   dropping them. Unless, of course, you insist on verifying all of them
   for each and every update. ;)   Basically, upstream's configure script
   ought to check the available build dependencies. That's enough. Trying
   to keep such versions in sync with updates results in a maintenance
   nightmare.

 * -devel package sub-section ought to do
   "Requires: %{name} = %{version}-%{release}
   with full %release to keep -devel package and main package in sync.

 * Missing dependencies on the tools used in the scriptlets:
   Requires(post): desktop-file-utils scrollkeeper
   Requires(postun): desktop-file-utils scrollkeeper

   Although, running update-desktop-database in the scriptlets is not
   necessary for this package [yet].


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.