[Bug 176591] Review Request: php-json: An extremely fast PHP extension for JSON

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-json: An extremely fast PHP extension for JSON


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176591





------- Additional Comments From dmitry at butskoy.name  2005-12-28 08:57 EST -------
OK

Remarks & nitpicks:
- autodetection of extdir and version can be simplified a little (as good
php-config always present in the Fedora's php-devel package)
- Use %{?dist} in the release field (as this package hardly depends to specific
distro's php version)
- Remove leading "An" from the summary
- Some %check section would be useful (at least to check that this module is
successfully attached at run-time and is visible by the /usr/bin/php).

See all these suggestions in the patch below.

I am confused a little by the fact there is no any documentation in this
package. Perhaps some data can be obtained from the upstream's site? (By simple
copying some *.html files etc.)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.