[Bug 176591] Review Request: php-json: An extremely fast PHP extension for JSON

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-json: An extremely fast PHP extension for JSON


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176591





------- Additional Comments From ivazquez at ivazquez.net  2005-12-30 22:31 EST -------
(In reply to comment #6)
> > Except when mock does its depsolving.
> Not understood how mock can have issues here, but it is not a blocker :)

mock looks at the bare spec file and evaluates it, possibly before any BRs have
been installed. Try it some day.

> > I always add that once it's in CVS.
> Why not before? IMO the PackageGuidelines requires it at review stage... Anyway,
> all other guys do it before CVS... 

Most all other guys don't have %dist defined on their system, and it gives the
buildsystem conniptions if I import it with %dist as .fc4 and then try to tag in
FC-4.

> - installed pam-json.html has execution bit set. Actually, "x" bit is set
> immediately after "install -p %{SOURCE1}". Perhaps changing "install" to "cp"
> can solve this.

No, this is because I misused install. Fixed.

> - Initially, I resisted to increase release numbers after each trivial change.
> But eventually various reviewers have forced me to do it always... ;)

It's not supposed to be used by the public yet, so I figure no harm, no foul.

Updated.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.