[Bug 173544] Review Request: xfce4-genmon-plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-genmon-plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173544





------- Additional Comments From fedora.wickert at arcor.de  2005-11-30 20:09 EST -------
(In reply to comment #2)
> 
> nits: 
> - Might tell upstream that the spec they ship has the License as BSD, which is
> wrong. 

just like in bug #173105, this is a relict from a xfce4-panel-sample-plugin package.

> 
> needswork:
> - source doesn't match upsteam. Looks like they recreated the tar in jan 2005,
> but you have the older version from 2004. 

fixed.

> - missing libxfcegui4-devel BuildRequires. 

fixed.
(Thanks for kickin my ass ;))

Also fixed %defattr(-,root,root,-) instead of (-,root,root)

NEW SRPM:
http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-genmon-plugin-1.1-4.fc4.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.