[Bug 174328] Review Request: tklib - a set of useful packages for Tk
bugzilla at redhat.com
bugzilla at redhat.com
Fri Dec 2 12:21:59 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: tklib - a set of useful packages for Tk
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174328
dmitry at butskoy.name changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |dmitry at butskoy.name
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From dmitry at butskoy.name 2005-12-02 07:21 EST -------
Remarks & nitpicks:
- spec file should not have execution bit set ("chmod -x tklib.spec")
- patch filename should have the upstream version included (for the moment the
patch is appeared), i.e. tklib-0.4.1-makecheck.patch
- remove leading "A" from the Summary field.
- add "rm -rf $RPM_BUILD_ROOT" into the beginning of %install section.
- IMHO it is a little more robust to use wildcards in the %files section.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list