[Bug 173040] Review Request: rlog - Runtime Logging for C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rlog - Runtime Logging for C++


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173040





------- Additional Comments From wtogami at redhat.com  2005-12-03 22:47 EST -------
(In reply to comment #6)
>> To make builds reproducible, you should either add the BuildRequires:
>> or use '--disable-valgrind'. Because it does not seem to introduce
>> additional dependencies, I do not see reasons to disable it.
> OK, added valgrind to BuildRequires

Is that valgrind only used for an optional build-time check?  One major drawback
of requiring valgrind during build is artificially limiting the architectures
that this can be included on.  valgrind's x86_64 support is very new, and it
doesn't run on ppc at all.  I would recommend disabling valgrind explicitly
during rpmbuild for this reason.

I would encourage you to please look into reviewing other contributor's packages
in order to demonstrate to the sponsors that you truly understand the packaging
guidelines and project processes, as that is the main thing we are looking for
in candidates for sponsorship.

I am considering sponsoring you soon, but I am looking more into your
participation first.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.