[Bug 174063] Review Request: cssed - css editor and validator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cssed - css editor and validator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174063





------- Additional Comments From fedora at iagorubio.com  2005-12-04 15:00 EST -------
> Apparently wrong.

> Proof: document.h is being installed and declares a lot of functions.

Those are some of the deprecated functions shipped for backward compatibility I
mentioned in my comment #10.
http://cssed.sourceforge.net/plugins-doc/accesing_docs.html

> None of them is exported from any binary.

As you know, G_MODULE_EXPORT can be considered boilerplate on Unix and Linux
systems as it's a macro that expands to nothing.

Only on Windows it have a meaning as it expands to __declspec(dllexport).

So this functions can still be accessed by Linux, Unix and OsX plugins despite
the lack of the G_MODULE_EXPORT macro.

This file is here for those in-house developers that used them in their plugins,
to give them a time frame to change those deprecated functions.

No cssed plugin uses any of the deprecated interface functions.

> Presence of useless files is not an actual problem, it's the fact they are
> meaningless and that your package's plugin API is a very doubtful (IMSNHO:
> bad) design.

Well, I cannot argue about that with you, and it's just the second release of
cssed exporting an API so it's sure it's not mature. In fact in the
documentation it's stated it's a draft.
http://cssed.sourceforge.net/plugins-doc/introduction.html#whos_this_for

But please let me point that you're judging a set of deprecated functions as
part of the API, and you're not taking into account when you stated they're
useless, that it have its uses for the reasons I stated above.

The actual API is contained in plugin.h. cssedwindow.h only contains definitions
and the other files - taking out scintilla headers - are the same case as
document.h.

As I said, I can take out the devel package - so take out all plugins if they're
a concern - or clean up the include directory to delete the deprecated functions.

If any other solution is required please let me know.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.