[Bug 175127] Review Request: wavbreaker - Tool for splitting .wav files

bugzilla at redhat.com bugzilla at redhat.com
Tue Dec 6 20:48:40 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wavbreaker - Tool for splitting .wav files


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175127


adrian at lisas.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |adrian at lisas.de
OtherBugsDependingO|                            |163778
              nThis|                            |




------- Additional Comments From adrian at lisas.de  2005-12-06 15:48 EST -------
This needs lot of work. The spec file is far from what is specified in the
guidelines at: http://fedoraproject.org/wiki/PackagingGuidelines

* Source needs full URL
* Strange release tag
* Buildroot should be as in the guidelines
* BR libxml2-devel, desktop-file-utils missing
* redundant "-n %{name}-%{version}" in %setup
* why has %configure --prefix added
* make needs smp flags if possible (else comment why not)
* use install -p instead of cp
* use of desktop-file-install is wrong
  (http://fedoraproject.org/wiki/PackagingGuidelines#desktop)
* does not build in mock:
checking for gtk+-2.0 gthread-2.0 libxml-2.0... Package libxml-2.0 was not found
in the pkg-config search path. Perhaps you should add the directory containing
`libxml-2.0.pc' to the PKG_CONFIG_PATH environment variable No package
'libxml-2.0' found
configure: error: Library requirements (gtk+-2.0 gthread-2.0 libxml-2.0) not
met; consider adjusting the PKG_CONFIG_PATH environment variable if your
libraries are in a nonstandard prefix so pkg-config can find them.
error: Bad exit status from /var/tmp/rpm-tmp.19644 (%build)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list