[Bug 175144] Review Request: munin - Network-wide graphing framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: munin - Network-wide graphing framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175144





------- Additional Comments From ed at eh3.com  2005-12-06 20:34 EST -------
Hi Kevin, this isn't a thorough review but it is a start:

nits:
 - rpmlint reports:
     E: munin non-standard-uid /var/www/html/munin munin
     E: munin non-standard-gid /var/www/html/munin munin
     E: munin non-standard-uid /var/log/munin munin
     E: munin non-standard-gid /var/log/munin munin
     E: munin non-standard-uid /var/lib/munin munin
     E: munin non-standard-gid /var/lib/munin munin
     E: munin non-standard-uid /var/run/munin munin
     E: munin non-standard-gid /var/run/munin munin
     E: munin-node non-standard-uid /var/lib/munin/plugin-state munin
     E: munin-node non-standard-gid /var/lib/munin/plugin-state munin
   which seem to be safe to ignore

 - running "yum localinstall [...the two noarch rpms...]"
   results in two errors:
     Error: Missing Dependency: perl(DBD::Sybase) is needed by \
       package munin-node
     Error: Missing Dependency: perl(Net::SNMP) is needed by \
       package munin-node
   which I have no idea how to fix.  Perhaps someone else has a clue
   whats happening here -- is it somehow pulling in unnecessary 
   dependencies...?

good:
 + source matches upstream
 + spec is readable and looks OK
 + code not content
 + builds in mock on FC-4
 + appears to use the correct syntax wrt user and group
     creation:  http://fedoraproject.org/wiki/PackageUserCreation
 + dir ownership looks good


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.