[Bug 173111] Review Request: <gDesklets-0.35.2-1>

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: <gDesklets-0.35.2-1>


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173111





------- Additional Comments From wtogami at redhat.com  2005-12-07 17:32 EST -------
Luya, please do not import packages until someone gives an explicit "APPROVED"
message here.

#%_install
#rm -rf ${RPM_BUILD_ROOT}
#make -e install DESTDIR=${RPM_BUILD_ROOT}

Why is this in the spec when it does nothing?

[ -n $RPM_BUILD_ROOT -a $RPM_BUILD_ROOT != / ] && rm -rf $RPM_BUILD_ROOT
This can always be simplified to rm -rf $RPM_BUILD_ROOT.  You may want to make
it look just like the one in %clean.  Keep things consistent.  Most specs don't
have an excessive use of {}'s around env var names, although it doesn't hurt I
guess.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.