[Bug 175291] Review Request: perl-PatchReader - utilities to read and manipulate patches and CVS

bugzilla at redhat.com bugzilla at redhat.com
Thu Dec 8 19:42:21 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-PatchReader - utilities to read and manipulate patches and CVS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175291


ville.skytta at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |ville.skytta at iki.fi
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From ville.skytta at iki.fi  2005-12-08 14:42 EST -------
Needswork'n'nitpicks:

- Uselessly redefines %{perl_vendor*}, doesn't need %{perl_vendorarch}
- Requires: perl(:MODULE_COMPAT_*) missing
- Doesn't run test suite during build
- Redundant %doc for man page
- Installs *.pm executable
- Off sync with many "best practices" from fedora-rpmdevtools' perl spec
  template

Here's my package which should be ready to roll; "|| :" could be removed from
%check and BuildRequires trimmed assuming recent perl packages though:
http://cachalot.mine.nu/4/SRPMS/perl-PatchReader-0.9.5-0.2.src.rpm

Note: the URLs you posted apparently use some kind of a frame hack which makes
them non-wgettable. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list