[Bug 166550] Review Request: synce-software-manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: synce-software-manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166550


jspaleta at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From jspaleta at gmail.com  2005-12-09 00:26 EST -------
Okay I've gone over the review. 2 blockers
1) Need to add BuildRequires: libgnomeui-devel
I fixed this to do my review and located here:
http://jef.is-a-geek.com/downloads/synce-software-manager/synce-software-manager-0.9.0-2.src.rpm
http://jef.is-a-geek.com/downloads/synce-software-manager/synce-software-manager.spec

2) Need to add a desktop file and associated scriptlet and Requires
I haven't fixed this, You'll need to add a .desktop as a SOURCE1 and then use
the instructions in http://www.fedoraproject.org/wiki/PackagingGuidelines for
Desktop Files.

Please add the desktop file and respin the srpm so I can do a final review of
the changes.

Full review:
- GOOD: builds in mock on an fc4 host system.
- GOOD: rpmlint returns clean.
- GOOD: The package is named according to the PackageNamingGuidelines.
- GOOD: The spec file name matches the base package %{name}
- GOOD: package meets the PackagingGuidelines.
- GOOD: The package is licensed with an open-source compatible license (MIT)
- GOOD: The License field in the package spec file matches the actual license.
- GOOD: The source package includes the text of the license(s) in its own file,
COPYING and is included in %doc.
- GOOD: The spec file is written American English.
- GOOD: The spec file for the package is be legible. 
- GOOD: The sources used to build the package match the upstream source.
- Fixed: The package must successfully compiles and build into binary rpms on
fc4 i386 and fc-devel i386.
        Needed to add BuildRequires: libgnomeui-devel 
- GOOD: package does not contain any BuildRequires that are listed in the
exceptions section of PackagingGuidelines.
- Fixed: All other Build dependencies must be listed in BuildRequires.
        Need to add BuildRequires: libgnomeui-devel
- GOOD: Uses the %find_lang macro.
- GOOD: No shared library files located in the dynamic linker's default paths
- GOOD: package owns all directories that it creates. 
- GOOD: package does not contain any duplicate files in the %files listing.
- GOOD: Permissions on files must be set properly. 
- GOOD: package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
- GOOD: package consistently use macros, as described in the macros section of
PackagingGuidelines.
- GOOD: package contains code, or permissable content. 
- GOOD: No large documentation files.
- GOOD: %doc files do not affect the runtime of the application. 
- GOOD: No header files or static libraries.
- GOOD: No files used by pkgconfig (.pc files).
- GOOD: No library files with a suffix (e.g. libfoo.so.1.1)


- BAD: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section. This is described in detail in the desktop files section of
PackagingGuidelines. If you feel that your packaged GUI application does not
need a .desktop file, you must put a comment in the spec file with your explanation.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.