[Bug 174486] Review Request: libopensync - A synchronization framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libopensync - A synchronization framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174486


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2005-12-09 23:00 EST -------
- rpmlint says:
W: libopensync no-version-in-last-changelog
W: libopensync conffile-without-noreplace-flag /etc/ld.so.conf.d/libopensync-32.conf
W: libopensync-debuginfo no-version-in-last-changelog
E: libopensync-debuginfo script-without-shellbang
/usr/src/debug/libopensync-0.18/opensync/opensync_internals.h
E: libopensync-debuginfo script-without-shellbang
/usr/src/debug/libopensync-0.18/opensync/opensync.h
E: libopensync-debuginfo script-without-shellbang
/usr/src/debug/libopensync-0.18/osengine/osengine_engine.c
E: libopensync-debuginfo script-without-shellbang
/usr/src/debug/libopensync-0.18/opensync/opensync_env.c
W: libopensync-devel no-version-in-last-changelog

* No, script-without-shellbang for debuginfo source isn't very important, though
a simple chmod -x on the files would fix it.
* ignoring changelog with the line break
* that conf file isn't going to be editing by user, ignoring noreplace

- package meets naming guidelines
- package meets packaging guidelines
- license (LGPL) OK, text in %doc, matches source
- spec file legible
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Take a look at:
Minor: %{_datadir}/opensync  directory empty, somewhat useless

Remove useless dir and chmod -x source and this is APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.