[Bug 169345] Review Request: SEC - Simple Event Correlator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SEC - Simple Event Correlator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169345


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |jpmahowald at gmail.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2005-12-10 11:51 EST -------
Is this your first package? If it is you'll need a sponsor.

rpmlint complains about:
W: sec incoherent-version-in-changelog 2.3.2-4 2.3.2-4%{_my_ext}
E: sec non-standard-executable-perm /usr/share/man/man1/sec.1.gz 0744
W: sec log-files-without-logrotate /var/log/sec.log
W: sec dangerous-command-in-%post rpm
W: sec dangerous-command-in-%preun rpm
W: sec dangerous-command-in-%postun rpm
E: sec no-status-entry /etc/rc.d/init.d/sec
E: sec no-chkconfig-line /etc/rc.d/init.d/sec

Some things to look at:
- release has an undeclared macro in it. Try "4%{?dist}" instead.
- Group is tricky, Applications/Text works well too.
- man page should be non executable
- add status command and chkconfig line to init script

Dangerous rpm commands are false alarms, they're commented out.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.