[Bug 171334] Review Request: nsd -
bugzilla at redhat.com
bugzilla at redhat.com
Sun Dec 11 22:52:47 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: nsd -
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=171334
tcallawa at redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |tcallawa at redhat.com
------- Additional Comments From tcallawa at redhat.com 2005-12-11 17:52 EST -------
There were some minor changes I made to your spec:
- used a %{?dist} tag (not mandatory, but good practice, IMHO)
- corrected Source path
(http://open.nlnetlabs.nl/downloads/nsd/%{name}-%{version}.tar.gz)
- moved rm -rf %{buildroot} from %prep to %install
- owned %dir %{_sysconfdir}/nsd/
- %{_mandir}/*/* doesn't need to be %doc, anything in %{_mandir} is %doc
automagically.
I'm going to attach the revised spec, I did the review off that spec file. Also,
note that 2.3.3 is out. You might want to update to that rev before committing.
Good:
- rpmlint checks return:
E: nsd non-executable-script /etc/nsd/nsdc.conf 0644
E: nsd postin-without-chkconfig /etc/rc.d/init.d/nsd
The nsdc.conf file has #!/bin/sh as its first line, but it's not a script (or
rather, its a shell script that does nothing but define variables). Safe to
ignore. The postin-without-chkconfig is also safe to ignore.
- package meets naming guidelines
- package meets packaging guidelines
- license (BSD-like) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
APPROVED (assuming that you use my spec file changes).
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list