[Bug 170372] Review Request: moodle: A Course Management System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: moodle: A Course Management System


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170372


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2005-12-12 00:32 EST -------
(In reply to comment #7)
> (In reply to comment #6)
> > E: moodle non-standard-uid /var/www/moodle/data apache
> > E: moodle non-standard-gid /var/www/moodle/data apache
> 
> Moodle needs to store data on the filesystem.
>
 
OK, ignoring.

> > E: moodle non-executable-script /var/www/moodle/web/admin/process_email.php 0644
> 
> Just a file with a shebang line, no biggie.
> 
> > E: moodle non-executable-script /var/www/moodle/web/mod/chat/chatd.php 0644
> 
> Interesting, a chat daemon written in PHP. I'm not sure how changing this will
> impact Moodle, although I feel it can be done easily enough once the package has
> been imported.
> 

OK, ignoring, as long as it works without execute bit.

> > E: moodle non-executable-script
> /var/www/moodle/web/mod/wiki/ewiki/fragments/mkhuge 0644
> 
> I could easily enough remove this, I suppose. Your call.
>

Keep. It's of limited use, but no harm done in keeping it.

 
> > E: moodle htaccess-file /var/www/moodle/web/auth/shibboleth/.htaccess
> 
> Needed for shibboleth auth, AFAICT.

OK.

> 
> > W: moodle non-conffile-in-etc /etc/cron.d/moodle
> 
> > None of the localization pacakges have docs, and a few have zero length php
file.
> 
> There are no non-English docs AFAICS. And I'm relutant to remove the zero-length
> files as I don't know how it will affect Moodle.

OK.


Ignoring all those and rpmlint doesn't like the 0755 perms on moodle init scripe
but matches those on my system.


- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc
- spec file legible
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- locales handled with the sub packages
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 
- works, imported sucessfully into mysql

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.