[Bug 169927] Review Request: scim-fcitx - Chinese IMEngine for SCIM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scim-fcitx - Chinese IMEngine for SCIM


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169927


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |jpmahowald at gmail.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2005-12-12 23:39 EST -------
* RPM name is OK
* Source scim-fcitx.3.1.1.tar.bz2 is the same as upstream
* Builds fine in mock
* rpmlint of scim-fcitx-tools looks OK
* File list of scim-fcitx-tools looks OK

Needs work:
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* rpmlint of scim-fcitx: Don't need empty file NEWS.
* File list of scim-fcitx: %{_datadir}/scim and %{_libdir}/scim are already
owned by scim package
* %defattr(-, root, root)  really should be %defattr(-, root, root,-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.