[Bug 175438] Review Request: smart -- Next generation package handling tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: smart -- Next generation package handling tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175438





------- Additional Comments From ville.skytta at iki.fi  2005-12-13 05:20 EST -------
(In reply to comment #10)
> - use %%python_sitelib instead of %%_libdir/... 

This will most likely break on x86_64.  I have no way to test it, but I'm pretty
sure that you should be using %python_sitearch instead (in fedora-rpmdevtools
python spec template terms).


> - added -usermode subpackage which contains consolehelper wrappers for 
>   smart and use it in the -gtk subpackage 

I wonder what benefit does having this in a subpackage have over just including
it in the main package or the -gtk subpackage?


> ok, I added xen0 + xenU

Please add xen-hypervisor and xen-guest too, that's the way they'll be called in
FC5.  Also, "kernel-devel" is not enough, there are -devel packages for all of
the variants (kernel-smp-devel etc).  Oh, and one typo: s/bigmen/bigmem/ (and
IIRC there's a hugemem kernel in RHEL too).

 
> > What rpm versions does Requires(missingok) work with?  (At least so
> > that the specfile parser groks it.)
> 
> Should not matter. 'smart' itself requires at least rpm 4.4 and this
> version understands '(missingok)'.

Wouldn't it be appropriate to add the corresponding versioned "BuildRequires:
rpm-build >= 4.4" and "Requires: rpm-python >= 4.4" dependencies, then?


> > ksmarttray build fails on FC5t1+rawhide, configure tries to use -lXt
> > but it isn't found.  BuildRequires: libXt-devel fixes it.
> 
> looks like a kdelibs-devel bug.

I'm not so sure about that, see contrib/ksmarttray/admin/acinclude.m4.in.  Many
configure scripts tend to test for X presence using Xt, even if they don't
actually use Xt themselves for anything else.


> When kdelibs-devel is not fixed till approval, I will add this
> buildrequires for the FC5 branch in the CVS. For now, I will assume
> builds on FC4.

Ack.

 
> I added a ksmarttray.desktop but do not know how to test it

I'll try it out and report back.


> I think, sudo is the correct tool. 'ksmarttray' seems to execute
> 'smart-update' regularly and I would dislike periodically appearing
> dialog boxes which are asking for a root password.

Good point.  OTOH consolehelper could be used to launch ksmarttray itself, but
I'm not 100% sure if that's the best approach either.  I won't consider this a
blocker (but others are of course free to disagree, though).


One new finding: -gtk has superfluous Requires(pre) and Requires(postun) for the
main package, probably a remainder from the ui(%name) and separate text UI
package times.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.