[Bug 175438] Review Request: smart -- Next generation package handling tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: smart -- Next generation package handling tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175438





------- Additional Comments From enrico.scholz at informatik.tu-chemnitz.de  2005-12-13 12:11 EST -------
* Tue Dec 13 2005 Enrico Scholz <enrico.scholz at informatik.tu-chemnitz.de> - 0.40-1.7
- use %%python_sitearch instead of %%python_sitelib
- added yet more variants for the multi-version kernel packages


==========



> > - use %%python_sitelib instead of %%_libdir/... 
> 
> This will most likely break on x86_64.  I have no way to test it, but
> I'm pretty sure that you should be using %python_sitearch instead (in
> fedora-rpmdevtools python spec template terms).

ok, I use sitearch now but can not test it


> > - added -usermode subpackage which contains consolehelper wrappers for 
> >   smart and use it in the -gtk subpackage 
> 
> I wonder what benefit does having this in a subpackage have over
> just including it in the main package or the -gtk subpackage?

* -usermode is not required for core-functionality
* -usermode adds non-trivial deps

==> -usermode can not be in the core package


* -usermode can be used for the text-interface too
* -gtk is not required for the text-interface

==> -usermode and -gtk should not be in the same package


> Wouldn't it be appropriate to add the corresponding versioned "BuildRequires:
> rpm-build >= 4.4" and "Requires: rpm-python >= 4.4" dependencies, then?

IMO, such versioned dependencies are pretty useless in the age of
missing-epoch == epoch-zero.  rpm does not provide a way to express a
dependency on a certain upstream version (e.g. 'rpm = 1:4.0' would
fulfill the Requires: but would not have the needed functionality).

Versioned deps can be used to exclude certain packages in a well-known
environment. And this well-known environment is FC4+ in this case
which is known to have the required 'rpm' package.


> One new finding: -gtk has superfluous Requires(pre) and
> Requires(postun) for the main package, probably a remainder from the
> ui(%name) and separate text UI package times.

It's intentionally. I want to make sure that 'smart-gtk' gets
installed after 'smart' and removed before it, because -gtk uses
directories from the base package which would stay when 'smart' is
removed before 'smart-gtk'.

afaik, pre/postun modifiers are the only way *guaranting* that.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.