[Bug 172871] Review Request: driftnet

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: driftnet


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172871


adrian at lisas.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From adrian at lisas.de  2005-12-13 14:40 EST -------
* rpmlint is almost happy:
W: driftnet conffile-without-noreplace-flag /etc/security/console.apps/driftnet
W: driftnet no-dependency-on usermode-consoleonly
(can be ignored from my point of view)
* clean installation and removal
* builds in "mock -r fedora-development-i386-core"
* source matches upstream
* spec looks good (almost; see below)
* patches look sane

APPROVED

driftnet-0.1.6-pam.config:

using "auth       include      system-auth" instead of "auth       required    
pam_stack.so service=system-auth" like other applications from rawhide would be
a good idea.

The other warnings are not nice but at least they do not say that it is a
security risk to use them. If you like you can of course fix more warnings :-)

One more fix would be necessary before you upload it. There is a rm -rf in %prep
this should be moved to the beginning of %install.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.