[Bug 174278] Review Request: tcldom - XML DOM bindings for Tcl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tcldom - XML DOM bindings for Tcl


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174278


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |jpmahowald at gmail.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2005-12-13 16:46 EST -------
- package meets naming guidelines
- package meets packaging guidelines
- license (BSD) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

- devel package ok
- devel requires base package n-v-r 

However,
- Have you tested this on 64 bit? %{_libdir} may prove problematic
- BuildRoot should be cleaned at the beginning of %install. 
- A bunch of compiler warnings, particularly in tcldomlibxml2.c. Be sure to tell
upstream about this, and show them your patch.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.