[Bug 175502] Review Request: perl-Gtk2-Spell

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Gtk2-Spell


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175502





------- Additional Comments From kevin at tummy.com  2005-12-13 20:00 EST -------
NOTE: I cannot sponsor, but here's a review. :)

Good: 
- Package name is good. 
- License is good and matches upstream (LGPL)
- Source is good and matches upstream
- builds fine on fc4/devel. 
- package seems to work as expected using the include test perl script. 

Minor:
- rpmlint warning: 
W: perl-Gtk2-Spell devel-file-in-non-devel-package
/usr/lib/perl5/vendor_perl/5.8.7/i386-linux-thread-multi/Gtk2/Spell/Install/gtk2spellperl.h
- why bother to use the %realname macro? Is the package name expected to change
very often? :) 
- why the 'echo n | ' in the build section? 
- Might include the Changelog file as a doc. 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.