[Bug 173035] Review Request: chmlib - Library for dealing with ITSS/CHM format files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: chmlib - Library for dealing with ITSS/CHM format files


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173035


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2005-12-14 23:04 EST -------
A couple warnings you want to tell upstream about, like "warning: "memcpy"
redefined"


- rpmlint's happy except for some no-documentation from the devel package
- package meets naming guidelines
- package meets packaging guidelines
- license (LGPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 


One change, the BuildRoot needs to be cleaned at the beginning of %install, like
%clean. Do this and this is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.