[Bug 174320] Review Request: gcdmaster - Gnome Audio CD mastering

bugzilla at redhat.com bugzilla at redhat.com
Fri Dec 16 10:18:48 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcdmaster - Gnome Audio CD mastering


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174320





------- Additional Comments From mpeters at mac.com  2005-12-16 05:18 EST -------
Good

* Named according to PackageNamingGuidelines
* Spec file matches base package name
* Package meets packaging guidelines
* Licensed with appropriate licence (GPL), matches license in upstream package
* Spec file written in understandable americano english
* md5sum of source tarball matches upstream
* builds in mock on fc4 x86
* No un-necessary BuildRequires
* No locales
* Package owns all directories it creates
* Proper perms and %defattr()
* No libtool files packaged
* Proper desktop file - proper update-mime-database & update-desktop-database in
scriptlets

* rpmlint output:
[mpeters at utility result]$ ls *.rpm
gcdmaster-1.2.1-1.fc4.i386.rpm  gcdmaster-debuginfo-1.2.1-1.fc4.i386.rpm
gcdmaster-1.2.1-1.fc4.src.rpm
[mpeters at utility result]$ rpmlint *.rpm
E: gcdmaster zero-length /usr/share/doc/gcdmaster-1.2.1/NEWS
[mpeters at utility result]$

build pretty clean:
[mpeters at utility result]$ grep "warning" build.log 
dlg_a.c:255: warning: ignoring return value of 'sscanf', declared with attribute
warn_unused_result
dlg_a.c:262: warning: ignoring return value of 'sscanf', declared with attribute
warn_unused_result
dlg_a.c:269: warning: ignoring return value of 'sscanf', declared with attribute
warn_unused_result
AudioCDView.cc:888: warning: ignoring return value of 'int sscanf(const char*,
const char*, ...)', declared with attribute warn_unused_result
warning: Could not canonicalize hostname: utility.mpeters.local
[mpeters at utility result]$ 

Needs Work

* Please remove the INSTALL file from %doc
It is meaningless to the end user.
* Please remove NEWS file - it's empty

Suggestions

Not required, would be nice though -

Allow for a user defined macro that will build with mp3 support if user has the
needed stuff for mp3 support. IE -

rpmbuild --define 'mp3 1' --rebuild src.rpm

would try to rebuild w/ mp3 support enabled.
I seem to remember some other packages that did this in the past, I think an
audio editing app did.

-=-
At any rate - with the removal of the INSTALL and NEWS from %doc, I'll approve

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list