[Bug 175895] Review Request: perl-DBD-XBase - Perl module for reading and writing the dbf files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DBD-XBase - Perl module for reading and writing the dbf files


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175895





------- Additional Comments From jpo at di.uminho.pt  2005-12-16 14:45 EST -------
(In reply to comment #1)
> Basically the package seems OK to me, but I am seeing 2 minor issues with it:
> 
> 1. The package contains /usr/bin/indexdump.
> This name ("indexdump") seems too general/generic to me for this specialized
> tools to have it in /usr/bin. May-be one should consider to split the
> applications out of the perl-module package into a separate application package.
> I am not sure.

Maybe renaming it to dbfindexdump in case of conflict?  The patch would have
to modified the Makefile.PL, some parts of the documentation, and at least a
test file.
 
> 2. Something it broken with the Makefile.
> The ./bin/indexdump being generated inside when running "make" contains 
> two "#!/usr/bin/perl -w" shebangs instead of one.

Corrected. Patched added to CVS (devel branch - tagged and built as release 2).

> Anyway, APPROVED

Thanks. 

PS - Still waiting for the FC-4 CVS branch creation.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.