[Bug 175748] Review Request: cacti

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cacti


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175748


gauret at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |gauret at free.fr
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From gauret at free.fr  2005-12-17 05:24 EST -------
Needs work:
* Use of buildroot is not consistant
  (wiki: PackagingGuidelines#UsingBuildRootOptFlags)
* No downloadable source. Please give the full URL in the Source tag.
* Group Application/System is not valid, it's "Applications/System" (with an s)
* /usr/share/cacti/rra/.placeholder and the log file are chmod 750 because of
the %attr definition in %files. The files should not be executable, so you
should change the lines in %files to :
%dir %attr(0755,cacti,cacti) %{_datadir}/%{name}/log/
%attr(0644,cacti,cacti) %{_datadir}/%{name}/log/*
%dir %attr(0755,cacti,cacti) %{_datadir}/%{name}/rra/
%attr(0644,cacti,cacti) %{_datadir}/%{name}/rra/.placeholder
* Is is necessary to make the log dir non world-readable ? I don't see important
information there. Plus, the log file has to be readable by the webserver for
the "View Log" function to work (in "System Utilities"). In the above example,
I've set the dir 755 and the log file 644.
* This is not FHS complient :
 - move include/config.php in /etc/cacti/config.php
 - move log/ to /var/log/cacti
 - move rra to /var/lib/cacti/rra/
And symlink the files back in /usr/share/cacti
I would also move scripts/ to /var/lib/cacti/scripts, since it is very common
for cacti users to add scripts. What do you think ?
* In %prep, use %setup -q to avoid file listing
* Please add a logrotate file for the log. Example:
/var/log/cacti/cacti.log {
    monthly
    notifempty
    missingok
    compress
    create 0644 cacti cacti
}
* File listed twice: /usr/share/cacti/include/config.php
* Missing dependancy on /sbin/service for %postun (package initscripts)
* /usr/bin should be changed to %{_bindir}
* Why "cp -avx" ? cp -a is enough
* Don't hardcode uid 329 in useradd, it may be already used. Just let useradd
find an available uid
* You need mailx and MTA as Requires(post) because of the mail in %post
* Changed Prereq to Requires(pre)
* No need for php in %pre, you can remove it from Requires(pre)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.