[Bug 175844] Review Request: wmx -- really simple and basic X window manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wmx -- really simple and basic X window manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175844


jeff at ultimateevil.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jeff at ultimateevil.org




------- Additional Comments From jeff at ultimateevil.org  2005-12-17 15:16 EST -------
I don't think it's necessary to include the package name in either Summary or
%description.  For example,

Summary: a really simple window manager for X

And %description should begin with a capital:  A really simple...

Next, it would be nice to include the appropriate facilities for this window
manager to show up in the xdm list of available sessions.  This can be done by
adding text files to /etc/X11/[g]dm/Sessions.  If it's gdm, the file would
simply be wmx, but if it's dm, it's wmx.desktop.  I'm looking at WindowMaker as
an example:

$ cat /etc/X11/gdm/Sessions/WindowMaker
#!/bin/sh
exec /etc/X11/xdm/Xsession wmaker
$ cat /etc/X11/dm/Sessions/WindowMaker.desktop
[Desktop Entry]
Encoding=UTF-8
Name=WindowMaker
Comment=Start Window Maker
Exec=wmaker
Type=Application

[Window Manager]
SessionManaged=true

Finally, in %files, I prefer to use %{_bindir}/* instead of naming the binary. 
Since this is only one in this case, it's up to you.  If the package ever grows
to include more binaries, it might be nice just to have the wildcard so there is
less to change in the future.  It's just a suggestion.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.