[Bug 167983] Review Request: evolution-caldav

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: evolution-caldav


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167983





------- Additional Comments From bdpepple at ameritech.net  2005-12-17 22:45 EST -------
NEEDSWORK

MD5Sums:
017b3739cc1a568708978344d48fc6f5  evolution-caldav-2.3.99.2.tar.bz2

Good:
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* All paths begin with macros
* All directories are owned by this or other packages
* No deprecated fields used
* All desired features are enabled

Needswork:
* Specified Source URL is not canonical.
* Missing Documentation: Add COPYING file.
* Requires for evolution, evolution-data-server, and libsoup can be dropped
since the BR should pull these in.
* Rpmlint errors (ran against binary provided by you): 
  E: evolution-caldav devel-dependency evolution-data-server-devel
  W: evolution-caldav no-documentation

Minor:
* Buildroot lacks certain elements
  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) is the
preferred value.  Refer to
http://fedoraproject.org/wiki/PackagingGuidelines#head-c2cfbc6be2860c5d2634d06714098e1560667de6

* Is "[ -n "$RPM_BUILD_ROOT" -a "$RPM_BUILD_ROOT" != / ]" really necessary in
the %install & %clean sections?

Note:
* I'm unable to build this currently in Mock, due to mesa-libGL being broken in
Rawhide.  Once this has been fixed, I'll try to build this package again.  Also,
since I'm not on Rawhide yet, someone else will need to verify that this package
runs as expected.  At a minimum, at least some of the reviewing needed for this
package is done.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.