[Bug 175748] Review Request: cacti

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cacti


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175748





------- Additional Comments From gauret at free.fr  2005-12-18 10:20 EST -------
> Simply running config.php out of /etc/ does not work as there are includes 
> that fail, and copying the entire include directory seems inapproperate.  I 
> could write a patch?

If it's very easy and obvious, yes, write a patch please. Users should not have
to edit configuration files in /usr/share

> I'm also curious about others thoughts on running this as a Cacti user.  Would
> it be more approperate to just run it as Apache?

You mean the cron job ? I think it's best not to run it as the apache user, so
that the apache user does not have write access to the RRA files in case of
compromise (and there have been such vulnerabilities in cacti's history)

* in %pre : /usr/sbin -> %{_sbindir}
* /var -> %{_localstatedir} in the logrotate file
* mailx and MTA should be in Requires(post)
* /sbin/service should be in Requires(postun)
* Using %doc in %files does the copying of files, so you don't have to do it in
%install

Minor:
* the scripts don't have to be owned by the cacti user, but that's not a problem
(it just spits out more warnings in rpmlint)
* you don't _have_ to use %{__install}, %{__mkdir}, %{__cp} and %{__chmod},
using install, mkdir, etc... is enough. Do what you prefer, it's up to you.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.